[webkit-reviews] review granted: [Bug 226048] [iOS][FCR] <select> options are unnecessarily truncated : [Attachment 429234] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 20 17:02:06 PDT 2021

Tim Horton <thorton at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 226048: [iOS][FCR] <select> options are unnecessarily truncated

Attachment 429234: Patch


--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 429234
  --> https://bugs.webkit.org/attachment.cgi?id=429234

View in context: https://bugs.webkit.org/attachment.cgi?id=429234&action=review

> Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:477
> +#define UIMenuOptionsPrivateRemoveLineLimitForChildren (1 << 6)

I think you want a WK prefix here? Or maybe it's OK and the compiler won't
whine if it has the real one because it's a #define?

Also, does UIKit ignore the random flag bit if it /doesn't/ have this change?

More information about the webkit-reviews mailing list