[webkit-reviews] review denied: [Bug 225923] loadURL not attributing requests as app bound : [Attachment 429123] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied
katherine_cheney at apple.com's request for review:
Bug 225923: loadURL not attributing requests as app bound
https://bugs.webkit.org/show_bug.cgi?id=225923

Attachment 429123: Patch

https://bugs.webkit.org/attachment.cgi?id=429123&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 429123
  --> https://bugs.webkit.org/attachment.cgi?id=429123
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429123&action=review

> Source/WebCore/ChangeLog:3
> +	   loadURL not attributing requests as app bound

FrameLoader:: would help understand what is going on here.

> Source/WebCore/loader/FrameLoader.cpp:1495
> +    addExtraFieldsToRequest(r, IsMainResource::Yes, m_loadType,
ShouldUpdateAppBoundValue::No);

We should probably rename addExtraFieldsToRequest because it's no longer just
about fields.

>
LayoutTests/http/tests/in-app-browser-privacy/app-bound-attribution-ping-load.h
tml:15
> +

extra space