[webkit-reviews] review granted: [Bug 225941] WKRemoteObjectRegistry _invokeMethod needs to check for nil completionHandlers : [Attachment 429105] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Julian Gonzalez
<julian_a_gonzalez at apple.com>'s request for review:
Bug 225941: WKRemoteObjectRegistry  _invokeMethod needs to check for nil
completionHandlers
https://bugs.webkit.org/show_bug.cgi?id=225941

Attachment 429105: Patch

https://bugs.webkit.org/attachment.cgi?id=429105&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 429105
  --> https://bugs.webkit.org/attachment.cgi?id=429105
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429105&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:51
> +    BOOL didCallSayHello = NO;

Don't we usually have curly brackets around the data members?

@implementation IPCTestingAPIDelegate {
    BOOL didCallSayHello;
}

Also, I don't believe we need the NO initializer in ObjC.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:161
> +    EXPECT_EQ([delegate.get() sayHelloWasCalled], NO);

EXPECT_FALSE([delegate.get() sayHelloWasCalled]);