[webkit-reviews] review granted: [Bug 225979] REGRESSION(r277505): Crash under WTF::Detail::CallableWrapper<WebKit::WebPageProxy::setUnderPageBackgroundColorOverride(WebCore::Color&&)::$_10, void>::call : [Attachment 429089] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 225979: REGRESSION(r277505): Crash under
WTF::Detail::CallableWrapper<WebKit::WebPageProxy::setUnderPageBackgroundColorO
verride(WebCore::Color&&)::$_10, void>::call
https://bugs.webkit.org/show_bug.cgi?id=225979

Attachment 429089: Patch

https://bugs.webkit.org/attachment.cgi?id=429089&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 429089
  --> https://bugs.webkit.org/attachment.cgi?id=429089
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429089&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:1958
> +	   if (m_pageClient)
> +	       didChangeBackgroundColor();

Hmm, I would expect it here if you had moved the dereferencing of m_pageClient
here, but inside didChangeBackgroundColor if you didn't. Why this version?