[webkit-reviews] review requested: [Bug 225616] [webkitscmpy] Cache identifiers in Git checkouts : [Attachment 429215] Add identifiers cache v2

[bugzilla-daemon at webkit.org]

Dean Johnson <dean_johnson at apple.com> has asked  for review:
Bug 225616: [webkitscmpy] Cache identifiers in Git checkouts
https://bugs.webkit.org/show_bug.cgi?id=225616

Attachment 429215: Add identifiers cache v2

https://bugs.webkit.org/attachment.cgi?id=429215&action=review




--- Comment #7 from Dean Johnson <dean_johnson at apple.com> ---
Created attachment 429215

  --> https://bugs.webkit.org/attachment.cgi?id=429215&action=review

Add identifiers cache v2

Fixed a couple test failures caused by refactoring. Still need to figure out
how to correctly handle remotes for these tests:

[1806/1995]
webkitscmpy.test.canonicalize_unittest.TestCanonicalize.test_branch_commits
failed:
  Traceback (most recent call last):
    File
"/Volumes/Data/dean-home/Projects/Safari/OpenSource/Tools/Scripts/libraries/web
kitscmpy/webkitscmpy/test/canonicalize_unittest.py", line 199, in
test_branch_commits
      self.assertEqual(commit_a.message, 'New commit 1\nIdentifier:
2.3 at branch-a')
  AssertionError: 'New commit 1\nIdentifier: 2.4 at branch-a' != 'New commit
1\nIdentifier: 2.3 at branch-a'
    New commit 1
  - Identifier: 2.4 at branch-a?		    ^
  + Identifier: 2.3 at branch-a?		    ^


[1823/1995]
webkitscmpy.test.checkout_unittest.TestCheckout.test_checkout_git_svn failed:
  Traceback (most recent call last):
    File
"/Volumes/Data/dean-home/Projects/Safari/OpenSource/Tools/Scripts/libraries/web
kitscmpy/webkitscmpy/test/checkout_unittest.py", line 62, in
test_checkout_git_svn
      self.assertEqual('621652add7fc416099bd2063366cc38ff61afe36',
local.Git(self.path).commit().hash)
  AssertionError: '621652add7fc416099bd2063366cc38ff61afe36' !=
'fff83bb2d9171b4d9196e977eb0508fd57e7a08d'
  - 621652add7fc416099bd2063366cc38ff61afe36
  + fff83bb2d9171b4d9196e977eb0508fd57e7a08d

And how to handle the broken SVN detection test:

[153/1995]
webkitpy.common.checkout.scm.detection_unittest.SCMDetectorTest.test_detect_scm
_system failed:
  Traceback (most recent call last):
    File
"/Volumes/Data/dean-home/Projects/Safari/OpenSource/Tools/Scripts/webkitpy/comm
on/checkout/scm/detection_unittest.py", line 49, in test_detect_scm_system
      self.assertEqual(
  AssertionError: "MOCK run_command: ['git', 'rev-parse',
'--is-inside-work-tree'], cwd=/\n" != "MOCK run_command: ['svn', 'info'],
cwd=/\nMOCK run_command: [[49 chars]=/\n"
  + MOCK run_command: ['svn', 'info'], cwd=/
    MOCK run_command: ['git', 'rev-parse', '--is-inside-work-tree'], cwd=/