[webkit-reviews] review granted: [Bug 226030] Move off UIKit IPI in WKMouseGestureRecognizer : [Attachment 429189] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 20 11:10:28 PDT 2021

Devin Rousso <drousso at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 226030: Move off UIKit IPI in WKMouseGestureRecognizer

Attachment 429189: Patch


--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 429189
  --> https://bugs.webkit.org/attachment.cgi?id=429189

View in context: https://bugs.webkit.org/attachment.cgi?id=429189&action=review


> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1662
> +    if (gestureRecognizer == _mouseGestureRecognizer)

NIT: Can we merge this with the above `if`?

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1687
> +    return gestureRecognizer != _mouseGestureRecognizer;

I think this needs to be in `#if HAVE(UIKIT_WITH_MOUSE_SUPPORT)`.

More information about the webkit-reviews mailing list