[webkit-reviews] review granted: [Bug 224471] Release assert in Document::updateLayout() via HTMLTextAreaElement::childrenChanged : [Attachment 429057] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 224471: Release assert in Document::updateLayout() via
HTMLTextAreaElement::childrenChanged
https://bugs.webkit.org/show_bug.cgi?id=224471

Attachment 429057: Patch

https://bugs.webkit.org/attachment.cgi?id=429057&action=review




--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 429057
  --> https://bugs.webkit.org/attachment.cgi?id=429057
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429057&action=review

>>> Source/WebCore/html/HTMLTextAreaElement.cpp:397
>>> +	 if (normalizedValue == value() || (normalizedValue.isEmpty() &&
value().isNull()))
>> 
>> Are you sure this works all the time even when the textarea has some child
nodes?
> 
> When the text area has some child nodes it does indeed early return as well
and thus it does not ever call all the other following methods which is perhaps
undesirable. I'll give it an extra thought.

ok.