[webkit-reviews] review granted: [Bug 223201] Mark ServiceWorkerThreadProxy with a default app-bound value : [Attachment 429090] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted katherine_cheney at apple.com's
request for review:
Bug 223201: Mark ServiceWorkerThreadProxy with a default app-bound value
https://bugs.webkit.org/show_bug.cgi?id=223201

Attachment 429090: Patch

https://bugs.webkit.org/attachment.cgi?id=429090&action=review




--- Comment #14 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 429090
  --> https://bugs.webkit.org/attachment.cgi?id=429090
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429090&action=review

> Source/WebCore/workers/service/server/SWServer.cpp:894
> +    }

Another approach would be to use m_clientsByRegistrableDomain to get the list
of service worker IDs for the client origin.
And then use m_runningOrTerminatingWorkers to get the worker from its id.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:2009
> +    }, TestWebKitAPI::HTTPServer::Protocol::Https);

Why do we need to create two servers? Can we just use one?