[webkit-reviews] review granted: [Bug 225910] VP9 powerEfficient detection is broken in STP124 : [Attachment 429136] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jean-Yves Avenard [:jya]
<jya at apple.com>'s request for review:
Bug 225910: VP9 powerEfficient detection is broken in STP124
https://bugs.webkit.org/show_bug.cgi?id=225910

Attachment 429136: Patch

https://bugs.webkit.org/attachment.cgi?id=429136&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 429136
  --> https://bugs.webkit.org/attachment.cgi?id=429136
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429136&action=review

> Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.h:66
> +    static void EnsureCodecsRegistered();

WebKit coding style uses a lowercase "E" for this kind of function name.

> Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm:67
> +    static bool sInitDone = []() {

We don’t normally use the "s" prefix for local variables. This idiom seems
pretty nice for one time code; we should probably adopt it.