[webkit-reviews] review requested: [Bug 225948] Speed up debug validation in CacheableIdentifier::createFromIdentifierOwnedByCodeBlock(). : [Attachment 429025] proposed patch.

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 225948: Speed up debug validation in
CacheableIdentifier::createFromIdentifierOwnedByCodeBlock().
https://bugs.webkit.org/show_bug.cgi?id=225948

Attachment 429025: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=429025&action=review




--- Comment #8 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 429025
  --> https://bugs.webkit.org/attachment.cgi?id=429025
proposed patch.

OK, all is well.  Just wanted to verify that
m_jitCode->dfgCommon()->m_dfgIdentifiers is only set once, and not appended to.
 It is indeed only set once in DesiredIdentifiers::reallyAdd().  Hence, the
number of identifiers are fixed and will not grow.