[webkit-reviews] review granted: [Bug 225940] Link Baseline JIT code off the main thread : [Attachment 428998] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 18 16:42:27 PDT 2021


Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 225940: Link Baseline JIT code off the main thread
https://bugs.webkit.org/show_bug.cgi?id=225940

Attachment 428998: patch

https://bugs.webkit.org/attachment.cgi?id=428998&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 428998
  --> https://bugs.webkit.org/attachment.cgi?id=428998
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428998&action=review

r=me

> Source/JavaScriptCore/jit/JIT.cpp:1008
> +    if (!m_jitCode)

Let's add assertion that ensures this is not compilation thread.


More information about the webkit-reviews mailing list