[webkit-reviews] review granted: [Bug 225938] REGRESSION (r275013): Trying to navigate in a WKWebView from a command line tool crashes the Web Content process : [Attachment 428981] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 225938: REGRESSION (r275013): Trying to navigate in a WKWebView from a
command line tool crashes the Web Content process
https://bugs.webkit.org/show_bug.cgi?id=225938

Attachment 428981: Patch

https://bugs.webkit.org/attachment.cgi?id=428981&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 428981
  --> https://bugs.webkit.org/attachment.cgi?id=428981
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428981&action=review

>
Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.
h:122
> +    delegate.getClientBundleIdentifier(parameters.clientBundleIdentifier);

It would be nice if you could make these not return-by-reference.  This looks
like it has no side effects, but it does.