[webkit-reviews] review granted: [Bug 225898] [lint-test-expectations] Change shebang to Python 3 : [Attachment 428898] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 18 08:40:44 PDT 2021


Aakash Jain <aakash_jain at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 225898: [lint-test-expectations] Change shebang to Python 3
https://bugs.webkit.org/show_bug.cgi?id=225898

Attachment 428898: Patch

https://bugs.webkit.org/attachment.cgi?id=428898&action=review




--- Comment #3 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 428898
  --> https://bugs.webkit.org/attachment.cgi?id=428898
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428898&action=review

> Tools/Scripts/webkitpy/common/version_check.py:-32
> -if sys.version < '2.7' or sys.version >= '2.8':

Are we dropping support for 2.7? If so, it would a good idea to have exit early
here if this code is run with python 2.7 (or atleast print a warning that
python 2.7 is not supported anymore).


More information about the webkit-reviews mailing list