[webkit-reviews] review granted: [Bug 225887] Clean up code distinguishing between webgl/webgl2 contexts : [Attachment 428870] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 17 23:05:36 PDT 2021


Darin Adler <darin at apple.com> has granted Kenneth Russell <kbr at google.com>'s
request for review:
Bug 225887: Clean up code distinguishing between webgl/webgl2 contexts
https://bugs.webkit.org/show_bug.cgi?id=225887

Attachment 428870: Patch

https://bugs.webkit.org/attachment.cgi?id=428870&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 428870
  --> https://bugs.webkit.org/attachment.cgi?id=428870
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428870&action=review

> Source/WebCore/html/HTMLCanvasElement.cpp:263
> +	       if ((version == WebGLVersion::WebGL1) !=
(m_context->isWebGL1()))

Extra set of parentheses here that you did not add below.


More information about the webkit-reviews mailing list