[webkit-reviews] review denied: [Bug 225800] [MSE] MediaSample that need to be removed with SourceBufferPrivate::evictCodedFrames() may not be removed. : [Attachment 428607] patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has denied Toshio Ogasawara
<toshio.ogasawara at access-company.com>'s request for review:
Bug 225800: [MSE] MediaSample that need to be removed with
SourceBufferPrivate::evictCodedFrames() may not be removed.
https://bugs.webkit.org/show_bug.cgi?id=225800

Attachment 428607: patch

https://bugs.webkit.org/attachment.cgi?id=428607&action=review




--- Comment #2 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 428607
  --> https://bugs.webkit.org/attachment.cgi?id=428607
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428607&action=review

> Source/WebCore/platform/graphics/SourceBufferPrivate.cpp:703
> -    while (rangeStart > minimumRangeStart) {
> +    while (rangeEnd > minimumRangeStart) {

Comparing `rangeEnd` to `mininimumRangeStart` feels wrong here.  Perhaps we
just need to restructure this code to correctly set `minimumRangeStart` to the
beginning of the next buffered range, if that time is > `minimumRangeStart`. 
Then this while loop can look identical to the while loop above.