[webkit-reviews] review granted: [Bug 225219] SHOULD NEVER BE REACHED in FrameSelection::setSelectionWithoutUpdatingAppearance for editing/selection/selection-in-iframe-removed-crash.html : [Attachment 428856] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 225219: SHOULD NEVER BE REACHED in
FrameSelection::setSelectionWithoutUpdatingAppearance for
editing/selection/selection-in-iframe-removed-crash.html
https://bugs.webkit.org/show_bug.cgi?id=225219

Attachment 428856: Patch

https://bugs.webkit.org/attachment.cgi?id=428856&action=review




--- Comment #11 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 428856
  --> https://bugs.webkit.org/attachment.cgi?id=428856
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428856&action=review

> LayoutTests/ChangeLog:10
> +	   editing/selection/selection-in-iframe-removed-crash.html, with the
timeout changed to 50
> +	   instead of 0.

Why 50ms? That sounds rather arbitrary. Can we requestAnimationFrame instead
for example?
Also, you're missing the expected result.

> LayoutTests/editing/selection/selection-in-iframe-removed-2-crash.html:3
> +Test passes if it does not crash.

You mean hit any assertions?