[webkit-reviews] review granted: [Bug 223758] [WebIDL] Remove [ImplicitThis] and [CustomProxyToJSObject] extended attributes : [Attachment 428841] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 223758: [WebIDL] Remove [ImplicitThis] and [CustomProxyToJSObject] extended
attributes
https://bugs.webkit.org/show_bug.cgi?id=223758

Attachment 428841: Patch

https://bugs.webkit.org/attachment.cgi?id=428841&action=review




--- Comment #8 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 428841
  --> https://bugs.webkit.org/attachment.cgi?id=428841
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428841&action=review

> Source/WebCore/bindings/js/JSDOMCastThisValue.h:45
> +template<class JSClass>
> +inline JSClass* castThisValue(JSC::JSGlobalObject& lexicalGlobalObject,
JSC::JSValue thisValue)

I think the inline is implicit and not needed in cases like this.

> Source/WebCore/bindings/js/JSDOMGlobalObject.h:157
> +template<class JSClass>
> +inline JSClass* toJSDOMGlobalObject(JSC::VM& vm, JSC::JSValue value)

Same comment about inline.