[webkit-reviews] review granted: [Bug 225829] WebFrameLoaderClient::dispatchWillSendRequest sometimes resets app-bound value : [Attachment 428846] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted
katherine_cheney at apple.com's request for review:
Bug 225829: WebFrameLoaderClient::dispatchWillSendRequest sometimes resets
app-bound value
https://bugs.webkit.org/show_bug.cgi?id=225829

Attachment 428846: Patch

https://bugs.webkit.org/attachment.cgi?id=428846&action=review




--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 428846
  --> https://bugs.webkit.org/attachment.cgi?id=428846
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428846&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacyPlugIn.mm:33
> +#import <WebKit/WKWebProcessPlugInRangeHandle.h>

Unused includes.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacyPlugIn.mm:47
> +- (void)webProcessPlugIn:(WKWebProcessPlugInController *)plugInController
didCreateBrowserContextController:(WKWebProcessPlugInBrowserContextController
*)browserContextController

All this is probably unnecessary.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacyPlugIn.mm:59
> +    return [[NSURLRequest alloc] initWithURL:request.URL];

This needs an autorelease.