[webkit-reviews] review denied: [Bug 225696] Resurrect WKWebView media controls API removed in https://bugs.webkit.org/show_bug.cgi?id=221929 : [Attachment 428814] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied youenn fablet
<youennf at gmail.com>'s request for review:
Bug 225696: Resurrect WKWebView media controls API removed in
https://bugs.webkit.org/show_bug.cgi?id=221929
https://bugs.webkit.org/show_bug.cgi?id=225696

Attachment 428814: Patch

https://bugs.webkit.org/attachment.cgi?id=428814&action=review




--- Comment #13 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 428814
  --> https://bugs.webkit.org/attachment.cgi?id=428814
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428814&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.h:377
> +- (void)requestMediaPlaybackState:(void
(^)(WKMediaPlaybackState))completionHandler
WK_API_DEPRECATED_WITH_REPLACEMENT("requestMediaPlaybackStateWithCompletionHand
ler:", macos(11.3, WK_MAC_TBA), ios(14.5, WK_IOS_TBA));

We shouldn't use WK_MAC_TBA or WK_IOS_TBA here.  It should be this:
macos(11.3, 11.3), ios(14.5, 14.5)
I'm also not convinced we should do this at all