[webkit-reviews] review granted: [Bug 225867] [GTK] [2.33.1] Fails to build when HAVE_OPENGL_ES_3 is on : [Attachment 428830] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Alberto Garcia
<berto at igalia.com>'s request for review:
Bug 225867: [GTK] [2.33.1] Fails to build when HAVE_OPENGL_ES_3 is on
https://bugs.webkit.org/show_bug.cgi?id=225867

Attachment 428830: Patch

https://bugs.webkit.org/attachment.cgi?id=428830&action=review




--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 428830
  --> https://bugs.webkit.org/attachment.cgi?id=428830
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428830&action=review

>> Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLES.h:40
>>  #include <GLES2/gl2ext.h>
> 
> We want *both* the GLES3 header *and* the GLES2 headers...?

IIUC any GLES3 implementation needs to *also* be a GLES2 implementation, and
including both should be harmless. As a matter of fact libGLESv2.so is expected
to provide both the GLES2 + GLES3 symbols, too :)