[webkit-reviews] review granted: [Bug 225839] Move CFStringRef and NSString support from StringBuilder into StringConcatenateCF : [Attachment 428759] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 225839: Move CFStringRef and NSString support from StringBuilder into
StringConcatenateCF
https://bugs.webkit.org/show_bug.cgi?id=225839

Attachment 428759: Patch

https://bugs.webkit.org/attachment.cgi?id=428759&action=review




--- Comment #10 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 428759
  --> https://bugs.webkit.org/attachment.cgi?id=428759
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428759&action=review

> Source/WTF/wtf/text/StringBuilder.h:124
> +    LChar* m_bufferCharacters { nullptr };

What is the intent of removing the union here and replacing its uses with
reinterpret_casts<>? An alternative formulation we could consider (though it
may have downsides I am not considering) is using a Variant<LChar*, UChar*> and
removing the m_is8Bit bool.

> Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:327
>      Color textColor = captionsTextColor(important);

auto?