[webkit-reviews] review granted: [Bug 225829] WebFrameLoaderClient::dispatchWillSendRequest sometimes resets app-bound value : [Attachment 428669] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted katherine_cheney at apple.com's request
for review:
Bug 225829: WebFrameLoaderClient::dispatchWillSendRequest sometimes resets
app-bound value
https://bugs.webkit.org/show_bug.cgi?id=225829

Attachment 428669: Patch

https://bugs.webkit.org/attachment.cgi?id=428669&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 428669
  --> https://bugs.webkit.org/attachment.cgi?id=428669
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428669&action=review

> Source/WebKit/ChangeLog:10
> +	   No new tests, was not able to reproduce this in our testing
> +	   infrastructure, only in real use cases. I tested this manually.

This is risky. Seems likely we’ll make the similar mistake again if we can’t
test it. We should consider how to enhance our testing machinery so we can test
it. Probably means adding a case of an injected bundle client that implements
willSendRequest and an API test.