[webkit-reviews] review granted: [Bug 225840] StructureRareData::m_replacementWatchpointSets should not be a pointer to a pointer : [Attachment 428705] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 225840: StructureRareData::m_replacementWatchpointSets should not be a
pointer to a pointer
https://bugs.webkit.org/show_bug.cgi?id=225840

Attachment 428705: Patch

https://bugs.webkit.org/attachment.cgi?id=428705&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 428705
  --> https://bugs.webkit.org/attachment.cgi?id=428705
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428705&action=review

r=me

> Source/JavaScriptCore/runtime/StructureRareData.h:130
>      typedef HashMap<PropertyOffset, RefPtr<WatchpointSet>,
WTF::IntHash<PropertyOffset>,
WTF::UnsignedWithZeroKeyHashTraits<PropertyOffset>> PropertyWatchpointMap;

nit: maybe add `static_assert(sizeof(PropertyWatchpointMap) == sizeof(void*));`
after this line?