[webkit-reviews] review granted: [Bug 225820] Drop FileSystem::fileMetadata() / fileMetadataFollowingSymlinks() : [Attachment 428685] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 14 20:20:06 PDT 2021
Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 225820: Drop FileSystem::fileMetadata() / fileMetadataFollowingSymlinks()
https://bugs.webkit.org/show_bug.cgi?id=225820
Attachment 428685: Patch
https://bugs.webkit.org/attachment.cgi?id=428685&action=review
--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 428685
--> https://bugs.webkit.org/attachment.cgi?id=428685
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=428685&action=review
> Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:716
> + auto fileType = FileSystem::fileTypeFollowingSymlinks(path);
> + bool isDirectory = fileType && *fileType ==
FileSystem::FileType::Directory;
The == operator in Optional should make this easier to write. Like this:
bool isDirectory = FileSystem::fileTypeFollowingSymlinks(path) ==
FileSystem::FileType::Directory;
> Source/WebCore/fileapi/File.cpp:151
> + auto fileType = FileSystem::fileTypeFollowingSymlinks(m_path);
> + m_isDirectory = fileType && *fileType ==
FileSystem::FileType::Directory;
m_isDirectory = FileSystem::fileTypeFollowingSymlinks(m_path) ==
FileSystem::FileType::Directory;
> Source/WebCore/html/DirectoryFileListCreator.cpp:79
> + auto fileType = FileSystem::fileType(info.path);
> + if (fileType && *fileType == FileSystem::FileType::Directory)
if (FileSystem::fileType(info.path) == FileSystem::FileType::Directory)
> Source/WebKit/NetworkProcess/cache/NetworkCacheFileSystem.cpp:62
> + auto fileType = FileSystem::fileType(entryPath);
> + auto type = (fileType && *fileType ==
FileSystem::FileType::Directory) ? DirectoryEntryType::Directory :
DirectoryEntryType::File;
auto type = FileSystem::fileType(entryPath) == FileSystem::FileType::Directory
? DirectoryEntryType::Directory : DirectoryEntryType::File;
> Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:368
> + auto directoryType = FileSystem::fileType(info.directoryPath);
> + if (directoryType && *directoryType ==
FileSystem::FileType::Directory) {
if (FileSystem::fileType(info.directoryPath) ==
FileSystem::FileType::Directory) {
> Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm:392
> + auto fileType =
FileSystem::fileTypeFollowingSymlinks(info.directoryPath);
> + hasSandboxDirectory = fileType && *fileType ==
FileSystem::FileType::Directory;
hasSandboxDirectory = FileSystem::fileTypeFollowingSymlinks(info.directoryPath)
== FileSystem::FileType::Directory;
More information about the webkit-reviews
mailing list