[webkit-reviews] review granted: [Bug 196532] output element doesn't react properly to node tree mutations : [Attachment 428665] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 196532: output element doesn't react properly to node tree mutations
https://bugs.webkit.org/show_bug.cgi?id=196532

Attachment 428665: Patch

https://bugs.webkit.org/attachment.cgi?id=428665&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
The test seems to not match the specification. The test has a test case where
the output element's value is set to the string "some". The specification says
that should do a string replace all operation with that value. One result of
that is that all the children are replaced. The test then sets the textContent
of a child element to "y". But after the replace all operation, that child
element is no longer one of the children, so that has no effect. The test
expects that output.value will be "y" after that operation.

Added a comment about this in GitHub:
https://github.com/web-platform-tests/wpt/pull/16080/commits/610c0a602dc302c992
7ab976f0e75a60c505ab33#r632250067

--- Comment #7 from Darin Adler <darin at apple.com> ---
Created attachment 428597

  --> https://bugs.webkit.org/attachment.cgi?id=428597&action=review

Patch

--- Comment #8 from Darin Adler <darin at apple.com> ---
I opened <https://github.com/web-platform-tests/wpt/issues/28994>. Anne, would
love to hear your take on this.

--- Comment #9 from Darin Adler <darin at apple.com> ---
Created attachment 428600

  --> https://bugs.webkit.org/attachment.cgi?id=428600&action=review

Patch

--- Comment #10 from Darin Adler <darin at apple.com> ---
Created attachment 428603

  --> https://bugs.webkit.org/attachment.cgi?id=428603&action=review

Patch

--- Comment #11 from Darin Adler <darin at apple.com> ---
All those EWS bubbles green; hoping for review soon.

--- Comment #12 from Darin Adler <darin at apple.com> ---
Created attachment 428665

  --> https://bugs.webkit.org/attachment.cgi?id=428665&action=review

Patch

--- Comment #13 from Darin Adler <darin at apple.com> ---
Good news, the bug in the test was fixed back in March.

--- Comment #14 from EWS Watchlist <ews-watchlist at webkit.org> ---
This patch modifies the imported WPT tests. Please ensure that any changes on
the tests (not coming from a WPT import) are exported to WPT. Please see
https://trac.webkit.org/wiki/WPTExportProcess