[webkit-reviews] review granted: [Bug 208049] Javascript can't access a SameSite=Strict cookie after page is loaded after a redirect from a third party site : [Attachment 428675] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted John Wilander <wilander at apple.com>'s
request for review:
Bug 208049: Javascript can't access a SameSite=Strict cookie after page is
loaded after a redirect from a third party site
https://bugs.webkit.org/show_bug.cgi?id=208049

Attachment 428675: Patch

https://bugs.webkit.org/attachment.cgi?id=428675&action=review




--- Comment #29 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 428675
  --> https://bugs.webkit.org/attachment.cgi?id=428675
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428675&action=review

r=me with nit

> Source/WebCore/loader/CookieJar.h:71
> +    static SameSiteInfo sameSiteInfo(const Document&, IsForDOMCookieAccess
isAccessForDOM = IsForDOMCookieAccess::No);

Can simply be: `IsForDOMCookieAccess = IsForDOMCookieAccess::No`. No need for
the parameter name.