[webkit-reviews] review granted: [Bug 225813] Use PixelBufferFormat to specify ImageBuffer::getPixelBuffer destination format allowing for more control over data conversion : [Attachment 428647] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 225813: Use PixelBufferFormat to specify ImageBuffer::getPixelBuffer
destination format allowing for more control over data conversion
https://bugs.webkit.org/show_bug.cgi?id=225813

Attachment 428647: Patch

https://bugs.webkit.org/attachment.cgi?id=428647&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 428647
  --> https://bugs.webkit.org/attachment.cgi?id=428647
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428647&action=review

Nice improvement here.

> Source/WebCore/platform/graphics/ImageBufferBackend.cpp:181
> +    unsigned sourceBytesPerRow = 4 * sourcePixelBuffer.size().width();

auto?

> Source/WebCore/platform/graphics/ImageBufferBackend.cpp:182
> +    const uint8_t* sourceRows = sourcePixelBuffer.data().data() +
sourceRectClipped.y() * sourceBytesPerRow + sourceRectClipped.x() * 4;

auto?

> Source/WebCore/platform/graphics/ImageBufferBackend.cpp:187
> +    PixelBufferFormat sourceFormat = sourcePixelBuffer.format();

auto?