[webkit-reviews] review granted: [Bug 225733] Resource Timing: secureConnectionStart == 0 when a connection is re-used : [Attachment 428550] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 225733: Resource Timing: secureConnectionStart == 0 when a connection is
re-used
https://bugs.webkit.org/show_bug.cgi?id=225733

Attachment 428550: Patch

https://bugs.webkit.org/attachment.cgi?id=428550&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 428550
  --> https://bugs.webkit.org/attachment.cgi?id=428550
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428550&action=review

r=me

> Source/WebCore/platform/network/cocoa/NetworkLoadMetrics.mm:33
> +static Box<WebCore::NetworkLoadMetrics> packageTimingData(double fetchStart,
double domainLookupStart, double domainLookupEnd, double connectStart, double
secureConnectionStart, double connectEnd, double requestStart, double
responseStart, bool reusedTLSConnection, NSString *protocol)

WebCore:: should not be necessary.

> Source/WebCore/platform/network/cocoa/NetworkLoadMetrics.mm:54
> +Box<WebCore::NetworkLoadMetrics>
copyTimingData(NSURLSessionTaskTransactionMetrics *incompleteMetrics)

ditto.