[webkit-reviews] review granted: [Bug 225797] Add ScriptDisallowedScope to MediaPlayerPrivateAVFoundation : [Attachment 428594] Adds ScriptDisallowedScope

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 225797: Add ScriptDisallowedScope to MediaPlayerPrivateAVFoundation
https://bugs.webkit.org/show_bug.cgi?id=225797

Attachment 428594: Adds ScriptDisallowedScope

https://bugs.webkit.org/attachment.cgi?id=428594&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 428594
  --> https://bugs.webkit.org/attachment.cgi?id=428594
Adds ScriptDisallowedScope

View in context: https://bugs.webkit.org/attachment.cgi?id=428594&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:3623
> +	       ScriptDisallowedScope scriptDisallowedScope;

Can't this use the less expensive `ScriptDisallowedScope::InMainThread`?

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:3722
> +	       ScriptDisallowedScope scriptDisallowedScope;

Ditto.

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:3755
> +	   ScriptDisallowedScope scriptDisallowedScope;

Ditto

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:3827
> +	       ScriptDisallowedScope scriptDisallowedScope;

Ditto