[webkit-reviews] review granted: [Bug 224204] [iOS] contextmenu hints can be clipped by the WKWebView : [Attachment 428575] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 224204: [iOS] contextmenu hints can be clipped by the WKWebView
https://bugs.webkit.org/show_bug.cgi?id=224204

Attachment 428575: Patch

https://bugs.webkit.org/attachment.cgi?id=428575&action=review




--- Comment #16 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 428575
  --> https://bugs.webkit.org/attachment.cgi?id=428575
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428575&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1133
> +- (void)cleanUpRelatedViews

Nit - "Related views" sounds a bit vague. What about something like
`-cleanUpPreviewContainers`?

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7668
> +    if (!_dropPreviewContainerView)
> +	   return;

Nit - I think you can remove this early return.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7687
> +    if (!_dragPreviewContainerView)
> +	   return;

(Ditto)

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7717
> +    if (!_contextMenuHintContainerView)
> +	   return;

(Ditto)

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:375
> +TEST(ContextMenu, DISABLED_HintPreviewContainer)

We should really investigate these at some point :/