[webkit-reviews] review granted: [Bug 225787] m_calleeSaveRegisters should not be a pointer to a pointer : [Attachment 428573] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 225787: m_calleeSaveRegisters should not be a pointer to a pointer
https://bugs.webkit.org/show_bug.cgi?id=225787

Attachment 428573: Patch

https://bugs.webkit.org/attachment.cgi?id=428573&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 428573
  --> https://bugs.webkit.org/attachment.cgi?id=428573
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428573&action=review

r=me with nits.

> Source/JavaScriptCore/bytecode/CodeBlock.h:287
> +	   bool m_hasCalleeSaveRegisters { false };

Can't we just add an operator bool to RegisterAtOffsetList which is true when
the FixedVector has a pointer?