[webkit-reviews] review granted: [Bug 225768] Rename FileSystem::directoryName() to FileSystem::parentPath() : [Attachment 428523] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 225768: Rename FileSystem::directoryName() to FileSystem::parentPath()
https://bugs.webkit.org/show_bug.cgi?id=225768

Attachment 428523: Patch

https://bugs.webkit.org/attachment.cgi?id=428523&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 428523
  --> https://bugs.webkit.org/attachment.cgi?id=428523
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428523&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:505
> +	   m_queue->dispatch([fetchOptions, applicationCacheDirectory =
m_configuration->applicationCacheDirectory().isolatedCopy(),
applicationCacheFlatFileSubdirectoryName =
m_configuration->applicationCacheFlatFileSubparentPath().isolatedCopy(),
callbackAggregator] {

We shouldn't do this one.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:730
> +	   m_queue->dispatch([applicationCacheDirectory =
m_configuration->applicationCacheDirectory().isolatedCopy(),
applicationCacheFlatFileSubdirectoryName =
m_configuration->applicationCacheFlatFileSubparentPath().isolatedCopy(),
callbackAggregator] {

Ditto.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:901
> +	   m_queue->dispatch([origins = WTFMove(origins),
applicationCacheDirectory =
m_configuration->applicationCacheDirectory().isolatedCopy(),
applicationCacheFlatFileSubdirectoryName =
m_configuration->applicationCacheFlatFileSubparentPath().isolatedCopy(),
callbackAggregator] {

Ditto.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:242
> +    const String& applicationCacheFlatFileSubparentPath() const { return
m_configuration->applicationCacheFlatFileSubparentPath(); }

Ditto.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:122
> +    const String& applicationCacheFlatFileSubparentPath() const { return
m_applicationCacheFlatFileSubdirectoryName; }
> +    void setApplicationCacheFlatFileSubparentPath(String&& directory) {
m_applicationCacheFlatFileSubdirectoryName = WTFMove(directory); }

Ditto.