[webkit-reviews] review granted: [Bug 225732] Remove StringBuilder::appendNumber : [Attachment 428458] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 13 08:29:08 PDT 2021
Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 225732: Remove StringBuilder::appendNumber
https://bugs.webkit.org/show_bug.cgi?id=225732
Attachment 428458: Patch
https://bugs.webkit.org/attachment.cgi?id=428458&action=review
--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 428458
--> https://bugs.webkit.org/attachment.cgi?id=428458
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=428458&action=review
> Source/WTF/ChangeLog:9
> + We originally added StringBuilder::appendNumber to resolve the
ambiguity
> + between UChar and uint16_t, but that problem was solved long ago and
it
I hadn't realized we had done this otherwise I would have totally done this
myself. That's great! Next up should we remove appendLiteral?
> Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:277
> + String errorMessage = makeString("Failed to load resource: the
server responded with a status of ", response.httpStatusCode(), " (",
response.httpStatusText(), ')');
I would leave out the String and use auto here.
More information about the webkit-reviews
mailing list