[webkit-reviews] review granted: [Bug 225763] [GTK] MiniBrowser: add support for saving multiple tabs in session state : [Attachment 428489] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 225763: [GTK] MiniBrowser: add support for saving multiple tabs in session
state
https://bugs.webkit.org/show_bug.cgi?id=225763

Attachment 428489: Patch

https://bugs.webkit.org/attachment.cgi?id=428489&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 428489
  --> https://bugs.webkit.org/attachment.cgi?id=428489
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428489&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:1463
> +    if (!g_key_file_load_from_file(session, sessionFile, G_KEY_FILE_NONE,
NULL)) {

I would check and print a warning if !g_error_matches(error, G_FILE_ERROR,
G_FILE_ERROR_NOENT). I think that's the only case where failure to restore the
session is expected. If the session state file contains data and we fail to
restore it, then that's probably a bug and warning developers is good to do.

> Tools/MiniBrowser/gtk/BrowserWindow.c:1476
> +
> +	   return;

This extra blank line doesn't seem like your usual code style?