[webkit-reviews] review granted: [Bug 225727] Add textIndicator bounce for AppHighlights on scroll. : [Attachment 428474] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 225727: Add textIndicator bounce for AppHighlights on scroll.
https://bugs.webkit.org/show_bug.cgi?id=225727

Attachment 428474: Patch

https://bugs.webkit.org/attachment.cgi?id=428474&action=review




--- Comment #10 from Tim Horton <thorton at apple.com> ---
Comment on attachment 428474
  --> https://bugs.webkit.org/attachment.cgi?id=428474
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428474&action=review

> Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:484
> +#if ENABLE(APP_HIGHLIGHTS)

What! Why is this guarded?

> Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:493
> +#if ENABLE(APP_HIGHLIGHTS)

No

> Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:502
> +#if ENABLE(APP_HIGHLIGHTS)

No

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:136
> +#if ENABLE(APP_HIGHLIGHTS)

Stop all of this madness :)

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:9590
> +#if ENABLE(APP_HIGHLIGHTS)

All of it!