[webkit-reviews] review granted: [Bug 216978] REGRESSION (r260276): Transform `scale()` removes round corners declared with `border-radius` on a hover state in Safari : [Attachment 428348] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Cameron McCormack (:heycam)
<heycam at apple.com>'s request for review:
Bug 216978: REGRESSION (r260276): Transform `scale()` removes round corners
declared with `border-radius` on a hover state in Safari
https://bugs.webkit.org/show_bug.cgi?id=216978

Attachment 428348: Patch

https://bugs.webkit.org/attachment.cgi?id=428348&action=review




--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 428348
  --> https://bugs.webkit.org/attachment.cgi?id=428348
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428348&action=review

It’s possible that one of the more layout-savvy people wants to look this over
too, but this looks obviously right to me.

> Source/WebCore/rendering/RenderLayer.cpp:4495
> +	   // FIXME: Do we need to set the posClipRect to be affected by
border-radius too?

Seems like our job is to come up with a test case for this so we don’t have to
leave a question behind in the code.

> LayoutTests/fast/layers/overflow-scroll-transform-border-radius.html:5
> +    <div id="e" style="width: 50px; height: 50px; background-color:
blue;"></div>

Not sure we need the id property here.