[webkit-reviews] review granted: [Bug 225539] Implement CanvasRenderingContext2D.createConicGradient : [Attachment 428402] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 12 16:24:04 PDT 2021

Sam Weinig <sam at webkit.org> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 225539: Implement CanvasRenderingContext2D.createConicGradient

Attachment 428402: Patch


--- Comment #8 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 428402
  --> https://bugs.webkit.org/attachment.cgi?id=428402

View in context: https://bugs.webkit.org/attachment.cgi?id=428402&action=review

> Source/WebCore/html/canvas/CanvasFillStrokeStyles.idl:47
> +    CanvasGradient createConicGradient(unrestricted double angle,
unrestricted double x, unrestricted double y);

Probably have some old tests to update, but looks good.

More information about the webkit-reviews mailing list