[webkit-reviews] review granted: [Bug 225707] Split pixel buffer format data out into a new PixelBufferFormat struct : [Attachment 428419] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 225707: Split pixel buffer format data out into a new PixelBufferFormat
struct
https://bugs.webkit.org/show_bug.cgi?id=225707

Attachment 428419: Patch

https://bugs.webkit.org/attachment.cgi?id=428419&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 428419
  --> https://bugs.webkit.org/attachment.cgi?id=428419
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428419&action=review

> Source/WebCore/platform/graphics/PixelBufferFormat.cpp:35
> +    return ts << pixelBuffer.alphaFormat << " " << pixelBuffer.pixelFormat
<< " " << pixelBuffer.colorSpace;

Faster if you use ' ' instead of " "?

> Source/WebCore/platform/graphics/PixelBufferFormat.h:50
> +    encoder << alphaFormat;
> +    encoder << pixelFormat;
> +    encoder << colorSpace;

Use the one-line form?

> Source/WebCore/platform/graphics/PixelFormat.h:40
> +WEBCORE_EXPORT WTF::TextStream& operator<<(WTF::TextStream&, PixelFormat);

Don’t need WTF prefix.