[webkit-reviews] review granted: [Bug 225372] [ BigSur Release ] TestWebKitAPI.IndexedDB.KillWebProcessWithOpenConnection is a constant failure : [Attachment 428408] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 225372: [ BigSur Release ]
TestWebKitAPI.IndexedDB.KillWebProcessWithOpenConnection is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=225372

Attachment 428408: Patch

https://bugs.webkit.org/attachment.cgi?id=428408&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 428408
  --> https://bugs.webkit.org/attachment.cgi?id=428408
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428408&action=review

>
Tools/TestWebKitAPI/Tests/WebKitCocoa/KillWebProcessWithOpenConnection-1.html:3
> +var db;

Why this?

>
Tools/TestWebKitAPI/Tests/WebKitCocoa/KillWebProcessWithOpenConnection-1.html:7
> +    db = event.target.result;

why not use var here?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:41
> +static bool readyToContinue;

You don't need a global here.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:111
> +    readyToContinue = false;

__block bool readyToContinue = false;