[webkit-reviews] review granted: [Bug 225709] Plumb some more metadata to QuickLook when revealing images : [Attachment 428401] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 12 12:31:52 PDT 2021

Devin Rousso <drousso at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 225709: Plumb some more metadata to QuickLook when revealing images

Attachment 428401: Patch


--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 428401
  --> https://bugs.webkit.org/attachment.cgi?id=428401

View in context: https://bugs.webkit.org/attachment.cgi?id=428401&action=review


> Source/WebKit/ChangeLog:26
> +	   Rename the `URL` argument to `fileURL`, to avoid confusion with the
new `imageURL` that's passed in. Note that
> +	   this is temporary, since we'll adopt new QuickLook SPI on macOS once
the fix for rdar://74299451 is available.

NIT: Should we put `FIXME` comments in the actual code for <rdar://74299451> so
somebody else knows where to look if needed?

More information about the webkit-reviews mailing list