[webkit-reviews] review granted: [Bug 225703] [TestWebKitAPI] Explicitly exit after completing tests : [Attachment 428385] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 12 11:27:43 PDT 2021


Alexey Proskuryakov <ap at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 225703: [TestWebKitAPI] Explicitly exit after completing tests
https://bugs.webkit.org/show_bug.cgi?id=225703

Attachment 428385: Patch

https://bugs.webkit.org/attachment.cgi?id=428385&action=review




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 428385
  --> https://bugs.webkit.org/attachment.cgi?id=428385
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428385&action=review

> Tools/TestWebKitAPI/ios/mainIOS.mm:56
> -    return passed ? EXIT_SUCCESS : EXIT_FAILURE;
> +    exit(passed ? EXIT_SUCCESS : EXIT_FAILURE);

If this works, it works, but please add a comment linking to a radar that
tracks investigating the root cause here.


More information about the webkit-reviews mailing list