[webkit-reviews] review granted: [Bug 225620] [iPad] SourceBufferPrivateAVFObjC should not report an error to the web page when the video playback is interrupted : [Attachment 428293] Make all changes for iOS only

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 12 10:09:49 PDT 2021


Jer Noble <jer.noble at apple.com> has granted Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 225620: [iPad] SourceBufferPrivateAVFObjC should not report an error to the
web page when the video playback is interrupted
https://bugs.webkit.org/show_bug.cgi?id=225620

Attachment 428293: Make all changes for iOS only

https://bugs.webkit.org/attachment.cgi?id=428293&action=review




--- Comment #6 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 428293
  --> https://bugs.webkit.org/attachment.cgi?id=428293
Make all changes for iOS only

View in context: https://bugs.webkit.org/attachment.cgi?id=428293&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:1206
> +#if PLATFORM(IOS_FAMILY)
> +    if (m_displayLayerWasInterrupted)
> +	   return false;
> +#endif

This will block appending samples to the audio renderer as well as the display
layer. Consider moving this inside the `if (trackID == m_enabledVideoTrackID)`
block below.

>
Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.m
m:1260
> +#if PLATFORM(IOS_FAMILY)
> +    if (m_displayLayerWasInterrupted)
> +	   return;
> +#endif

Ditto, and consider adding a call to `[m_displayLayer
stopRequestingMediaData];` before the return.


More information about the webkit-reviews mailing list