[webkit-reviews] review granted: [Bug 225603] Implement a remote Internal Unit in GPUProcess for audio MediaStreamTrack rendering : [Attachment 428369] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 12 09:31:22 PDT 2021


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 225603: Implement a remote Internal Unit in GPUProcess for audio
MediaStreamTrack rendering
https://bugs.webkit.org/show_bug.cgi?id=225603

Attachment 428369: Patch

https://bugs.webkit.org/attachment.cgi?id=428369&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 428369
  --> https://bugs.webkit.org/attachment.cgi?id=428369
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428369&action=review

>
Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitMa
nager.cpp:107
> +    for (auto proxy : m_proxies.values())
> +	   proxy->restartIfNeeded();

Will we want to always relaunch the GPU process as soon as it exits, e.g. if
under memory pressure?


More information about the webkit-reviews mailing list