[webkit-reviews] review granted: [Bug 225426] Add SPI to restrict networking to a set of hosts : [Attachment 427833] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 225426: Add SPI to restrict networking to a set of hosts
https://bugs.webkit.org/show_bug.cgi?id=225426

Attachment 427833: Patch

https://bugs.webkit.org/attachment.cgi?id=427833&action=review




--- Comment #5 from Tim Horton <thorton at apple.com> ---
Comment on attachment 427833
  --> https://bugs.webkit.org/attachment.cgi?id=427833
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427833&action=review

> Source/WebCore/page/Page.cpp:3307
> +    if (!url.protocolIsInHTTPFamily() && !url.protocolIs("ws") &&
!url.protocolIs("wss"))
> +	   return true;

Do we not have a helper somewhere else that is like "the host in this is a host
in the HTTP sense"? It seems weird for Page to know this