[webkit-reviews] review granted: [Bug 225556] Add web process drawing to the focus test in MotionMark : [Attachment 428079] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 11 10:35:33 PDT 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 225556: Add web process drawing to the focus test in MotionMark
https://bugs.webkit.org/show_bug.cgi?id=225556

Attachment 428079: Patch

https://bugs.webkit.org/attachment.cgi?id=428079&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 428079
  --> https://bugs.webkit.org/attachment.cgi?id=428079
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428079&action=review

>> PerformanceTests/ChangeLog:11
>> +	    the only thing we were doing was pushing layer state changes to the
window server.
> 
> This comment talks a lot about window server and Core Animation. But this is
a cross-platform, cross-browser benchmark, and window server is specific to
Mac, and Core Animation specific to Apple’s macOS/iOS/iPadOS/tvOS/watchOS.
> 
> I’m sure that these these improvements help us have a more repeatable test on
macOS, but are also helpful on other platforms, including iOS, and to
accurately test other web browsers as well. But that’s not stated here and
probably should be. We would not want to make the changes if they were harmful
in those other configurations.
> 
> I’m not sure we need quite so long a change log comment. Maybe there is
somewhere else we should leave this information if we are going to need it in
the future. In the change log it might or might not be found.

Agreed that we can trim down this changelog.


More information about the webkit-reviews mailing list