[webkit-reviews] review granted: [Bug 225631] [WebXR] Return a default layer handle in XRDeviceProxy::createLayerProjection : [Attachment 428233] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 10 18:34:00 PDT 2021


Dean Jackson <dino at apple.com> has granted Ada Chan <adachan at apple.com>'s
request for review:
Bug 225631: [WebXR] Return a default layer handle in
XRDeviceProxy::createLayerProjection
https://bugs.webkit.org/show_bug.cgi?id=225631

Attachment 428233: Patch

https://bugs.webkit.org/attachment.cgi?id=428233&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 428233
  --> https://bugs.webkit.org/attachment.cgi?id=428233
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428233&action=review

> Source/WebKit/UIProcess/Cocoa/PlatformXRCoordinator.h:44
> +    static PlatformXR::LayerHandle defaultLayerHandle() { return 1; }

Maybe put a FIXME here saying it needs to be fixed.


More information about the webkit-reviews mailing list