[webkit-reviews] review granted: [Bug 225522] [ macOS Release wk2 ] http/tests/cache-storage/cache-records-persistency.https.html is flaky crashing : [Attachment 428232] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 225522: [ macOS Release wk2 ]
http/tests/cache-storage/cache-records-persistency.https.html is flaky crashing
https://bugs.webkit.org/show_bug.cgi?id=225522

Attachment 428232: Patch

https://bugs.webkit.org/attachment.cgi?id=428232&action=review




--- Comment #12 from Darin Adler <darin at apple.com> ---
Comment on attachment 428232
  --> https://bugs.webkit.org/attachment.cgi?id=428232
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428232&action=review

> Source/WTF/ChangeLog:9
> +	   Pass ec parameter to std::filesystem::directory_iterator() so that
it doesn't throw in case of the

Did you search for other calls that forgot "ec"? Obviously if we accidentally
call any of the exception-throwing variants that is not good.