[webkit-reviews] review granted: [Bug 224900] Web Inspector: Network: rename "XHR" to "XHR/Fetch" : [Attachment 427631] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 224900: Web Inspector: Network: rename "XHR" to "XHR/Fetch"
https://bugs.webkit.org/show_bug.cgi?id=224900

Attachment 427631: Patch

https://bugs.webkit.org/attachment.cgi?id=427631&action=review




--- Comment #11 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 427631
  --> https://bugs.webkit.org/attachment.cgi?id=427631
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427631&action=review

>>> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:206
>>> +		 return WI.unlocalizedString("css");
>> 
>> Why lowercase on all these? I wouldn't change the case.
> 
> These we're all made lowercase at the callsite (old line 204).  I feel like
it's safer to have localizers do a translation of the lowercase value rather
than rely on JavaScript to do it for us.

Ah, eww.