[webkit-reviews] review denied: [Bug 225593] Remove unnecessary comparison and casting in GlyphBuffer.h : [Attachment 428166] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Eleni Maria Stea <estea at igalia.com>'s
request for review:
Bug 225593: Remove unnecessary comparison and casting in GlyphBuffer.h
https://bugs.webkit.org/show_bug.cgi?id=225593

Attachment 428166: Patch

https://bugs.webkit.org/attachment.cgi?id=428166&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 428166
  --> https://bugs.webkit.org/attachment.cgi?id=428166
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428166&action=review

> Source/WebCore/platform/graphics/GlyphBuffer.h:81
> -	   if (result < 0 || static_cast<unsigned>(result) >= stringLength)
> +	   if (result >= stringLength)

This is not true on all platforms. When USE(CG) is true,
GlyphBufferStringOffset (the type of result) is CFIndex which is 'signed long'.

The real issue that we should try to solve is using the same types here if we
can.