[webkit-reviews] review granted: [Bug 225580] Remove all remaining uses of the String::toInt family of functions : [Attachment 428143] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 225580: Remove all remaining uses of the String::toInt family of functions
https://bugs.webkit.org/show_bug.cgi?id=225580

Attachment 428143: Patch

https://bugs.webkit.org/attachment.cgi?id=428143&action=review




--- Comment #11 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 428143
  --> https://bugs.webkit.org/attachment.cgi?id=428143
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428143&action=review

> Source/WebCore/html/HTMLLIElement.cpp:122
> +    Optional<int> explicitValue;
> +    if (auto parsedValue = parseHTMLInteger(value))
> +	   explicitValue = *parsedValue;

If we have this pattern more (convert Expected<T, *> to Optional<T> we should
consider adding a makeOptional() or convertToOptional() that takes an Expected.